[wp-trac] [WordPress Trac] #28536: Add browser history and deep linking for navigation in Customizer preview

WordPress Trac noreply at wordpress.org
Sun Jun 15 19:52:00 UTC 2014


#28536: Add browser history and deep linking for navigation in Customizer preview
-------------------------+------------------------------
 Reporter:  westonruter  |       Owner:  ocean90
     Type:  enhancement  |      Status:  reviewing
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Appearance   |     Version:  3.4
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  ui, javascript
-------------------------+------------------------------

Comment (by westonruter):

 Humm, one more bug I'm noticing when using this in theme-switch Live
 Preview. The `window`is unavailable inside of the `popstate` event for
 some reason, which previously [https://github.com/x-team/wordpress-
 develop/commit/4cddbbe14b68cf91f34272a5b364b7dc75a3ae23 committed
 workarounds]. The issue is happening right here:

 {{{
 queryVars = self.parseQueryVars( location.search.substr( 1 ) );
 }}}

 I'm getting an exception:

 > Uncaught TypeError: Cannot read property 'substr' of undefined

 If I change `location` to `window.parent.location` then the error is:

 > Uncaught TypeError: Cannot read property 'parent' of null

 So again, the `window` becomes unavailable for some reason which I've not
 figured out yet.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28536#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list