[wp-trac] [WordPress Trac] #28543: Allow stricter JSHint checks for core files

WordPress Trac noreply at wordpress.org
Sun Jun 15 19:07:03 UTC 2014

#28543: Allow stricter JSHint checks for core files
 Reporter:  MattyRob          |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Build/Test Tools  |     Version:  trunk
 Severity:  trivial           |  Resolution:
 Keywords:  has-patch close   |     Focuses:  javascript

Comment (by MattyRob):

 Replying to [comment:2 jorbin]:
 > I think the route we should take here is to fix these two issues
 individually rather than introduce a new temporary grunt task that won't
 pass.  Introducing this task would cause the general jshint task to fail
 every single time until both curly and eqeqeq are fixed, and once they are
 fixed we wouldn't need this task.
 > We should handle turning off the curly and eqeqeq separately.  eqeqeq is
 going to be much harder, but curly is something we can definitely do.  I
 think we should close this ticket and open separate tickets for each of
 those two.

 I'm not sure that I fully understand what you are saying, are you saying
 that creating a new 'jshint:corestrict' task that can be invoked with a
 command of "grunt jshint:core strict" that the build tests will fail all
 the time? Why would this new task be called as part of the automated build
 tool tests?

 Perhaps your suggested way is cleaner by staging the removal of the
 current exclusions from 'jshint:core' and I did suggest that as an option

Ticket URL: <https://core.trac.wordpress.org/ticket/28543#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list