[wp-trac] [WordPress Trac] #28466: Remove unused/misleading variable in wpmu_signup_blog_notification()

[WordPress Trac]

#28466: Remove unused/misleading variable in wpmu_signup_blog_notification()
------------------------------------+------------------------
 Reporter:  iamfriendly             |       Owner:
     Type:  enhancement             |      Status:  closed
 Priority:  normal                  |   Milestone:
Component:  Login and Registration  |     Version:  trunk
 Severity:  normal                  |  Resolution:  wontfix
 Keywords:  has-patch               |     Focuses:  multisite
------------------------------------+------------------------
Changes (by jeremyfelt):

 * status:  new => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 The addition of this `$key` variable dates back to changeset
 [https://mu.trac.wordpress.org/changeset/1977 MU1977] due to the reasoning
 in ticket [https://mu.trac.wordpress.org/ticket/1119 MU1119]

 It's interesting the ticket mentions adding `$key` to the filter, though
 it's really adding it to be used in `sprintf()`.

 It is possible that somebody is using the
 `wpmu_signup_blog_notification_email` filter to alter the original message
 to account for that 3rd variable. Because of this, I don't think that we
 can remove it.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28466#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform