[wp-trac] [WordPress Trac] #28540: Introduce wpmu_create_blog meta filter
WordPress Trac
noreply at wordpress.org
Sun Jun 15 01:45:42 UTC 2014
#28540: Introduce wpmu_create_blog meta filter
--------------------------------+------------------------------
Reporter: Compute | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Networks and Sites | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses: multisite
--------------------------------+------------------------------
Changes (by jeremyfelt):
* type: feature request => enhancement
Comment:
Hi Compute, thanks for the ticket and the patch!
I'm not completely convinced we need this, as using `update_option()` to
add your data and perform other tasks while hooked into `wpmu_new_blog` is
pretty straight forward. The concept of "meta" here is also somewhat
misleading (to me), as the data doesn't end up in any meta table, but in
the new site's options.
The default data passed around as `$meta` here really amounts to whether
the site is public and what the `lang_id` option should be. There is a
filter on signups with `add_signup_meta` that could pass more in some
scenarios. It is somewhat strange that a filter exists there for modifying
the "meta" but nowhere else.
If this filter was added, looking at your patch, we would want to put it
above the `wp_parse_args()` line here so that we could continue to ensure
that defaults exist. The function relies on the existence of `public`
later on. Also check out how [http://make.wordpress.org/core/handbook
/inline-documentation-standards/php-documentation-standards/#4-hooks-
actions-and-filters hooks are now documented in core].
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28540#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list