[wp-trac] [WordPress Trac] #28517: Logic error in WP_Rewrite flush_rules

[WordPress Trac]

#28517: Logic error in WP_Rewrite flush_rules
---------------------------+------------------------------
 Reporter:  numis          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Rewrite Rules  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------

Comment (by numis):

 And a final correction.  The last scenario in the current code is actually
 a desired outcome:

 =============================================

 If $hard is false and a filter is added that returns false:

 {{{
 ! false || ! false = true || true = true
 }}}

 {{{
 #!html
 <span style="font-weight: bold; font-color: green;">INTENTIONAL SUCCESS -
 SOFT FLUSH PERFORMED</span>
 }}}

 =============================================

 Again, the attached patches still stand.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28517#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform