[wp-trac] [WordPress Trac] #28517: Logic error in WP_Rewrite flush_rules

[WordPress Trac]

#28517: Logic error in WP_Rewrite flush_rules
---------------------------+------------------------------
 Reporter:  numis          |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Rewrite Rules  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:
---------------------------+------------------------------
Changes (by numis):

 * keywords:   => has-patch


Comment:

 Attached are two patches:

 {{{
 #!html
 <span style="color: green; font-weight: strong;" >28517-with-
 tests.patch</span>:
 }}}
 * Corrects the logic error observed above.
 * Brings surrounding code up to the coding standards set forth in the PHP
 Coding Standards section of the WordPress Core Handbook.
 * Includes modifications necessary for the tests to assert against a
 return value, based on the type of flush that was attempted.
 * Includes 6 new tests in tests/rewrite.php:
  - test_flush_rules_hard_true_no_filters()
  - test_flush_rules_hard_false_no_filters()
  - test_flush_rules_hard_true_with_filters_true()
  - test_flush_rules_hard_true_with_filters_false()
  - test_flush_rules_hard_false_with_filters_true()
  - test_flush_rules_hard_false_with_filters_false()

 {{{
 #!html
 <span style="color: green; font-weight: strong;" >28517-without-
 tests.patch</span>:
 }}}
 * Corrects the logic error observed above.
 * Brings surrounding code up to the coding standards set forth in the PHP
 Coding Standards section of the WordPress Core Handbook.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28517#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform