[wp-trac] [WordPress Trac] #16268: Requirement for has_header_image() function?
WordPress Trac
noreply at wordpress.org
Wed Jun 11 15:24:21 UTC 2014
#16268: Requirement for has_header_image() function?
-------------------------+-----------------------------
Reporter: husobj | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Appearance | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: template
-------------------------+-----------------------------
Comment (by obenland):
Thanks for the patch, looks like it's a good first step in the right
direction!
A few things that came to mind:
* Patches should be created from the root directory of your WordPress SVN
install.
* The function body could probably be simplified by literally casting the
return value of `get_header_image()` to a bool.
* Feel free to check out the function documentation of other functions in
that file, to get a feel for wording and punctuation.
* The documentation could be misinterpreted as whether a theme has a
(registered) custom header. "Checks whether a header image is set." might
be more accurate.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/16268#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list