[wp-trac] [WordPress Trac] #22823: Texturize should handle apostrophes before primes

WordPress Trac noreply at wordpress.org
Tue Jun 10 02:35:21 UTC 2014


#22823: Texturize should handle apostrophes before primes
-------------------------------------------------+-------------------------
 Reporter:  nacin                                |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Future
Component:  Formatting                           |  Release
 Severity:  minor                                |     Version:  3.4.2
 Keywords:  has-patch wptexturize needs-refresh  |  Resolution:
                                                 |     Focuses:
-------------------------------------------------+-------------------------
Changes (by wonderboymusic):

 * keywords:  has-patch wptexturize => has-patch wptexturize needs-refresh


Comment:

 Broken tests with the patch:

 {{{
 1) Tests_Formatting_WPTexturize::test_minutes_seconds
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'9′'
 +'9’'

 /Users/scott/svn/wordpress-core-
 develop/tests/phpunit/tests/formatting/WPTexturize.php:141

 2) Tests_Formatting_WPTexturize::test_apos_before_digits with data set #5
 ('word \'99\'s word', 'word ’99′s word')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'word ’99′s word'
 +'word ’99’s word'

 /Users/scott/svn/wordpress-core-
 develop/tests/phpunit/tests/formatting/WPTexturize.php:290

 3) Tests_Formatting_WPTexturize::test_apos_before_digits with data set #6
 ('word \'99\'samsonite', 'word ’99′samsonite')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'word ’99′samsonite'
 +'word ’99’samsonite'

 /Users/scott/svn/wordpress-core-
 develop/tests/phpunit/tests/formatting/WPTexturize.php:290

 4) Tests_Formatting_WPTexturize::test_single_prime with data set #1 ('word
 99\'word', 'word 99′word')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'word 99′word'
 +'word 99’word'

 /Users/scott/svn/wordpress-core-
 develop/tests/phpunit/tests/formatting/WPTexturize.php:505

 5) Tests_Formatting_WPTexturize::test_single_prime with data set #3
 ('word99\'word', 'word99′word')
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'word99′word'
 +'word99’word'

 /Users/scott/svn/wordpress-core-
 develop/tests/phpunit/tests/formatting/WPTexturize.php:505

 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/22823#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list