[wp-trac] [WordPress Trac] #14867: HTTPS related issues in ms-blogs.php (with fix)

[WordPress Trac]

#14867: HTTPS related issues in ms-blogs.php (with fix)
--------------------------+--------------------------
 Reporter:  mareck        |       Owner:  johnbillion
     Type:  defect (bug)  |      Status:  accepted
 Priority:  normal        |   Milestone:  4.0
Component:  Permalinks    |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  multisite
--------------------------+--------------------------
Changes (by johnbillion):

 * keywords:  has-patch dev-feedback => needs-patch
 * owner:   => johnbillion
 * status:  reopened => accepted
 * milestone:  Future Release => 4.0


Comment:

 Note that `get_blogaddress_by_domain()` is now deprecated and not used in
 core so we don't need to worry about it.

 There seems to be some confusion about what scheme should be returned by
 these functions. The scheme is unrelated to the current scheme, so the
 suggested `is_ssl()` logic is unnecessary. The scheme that's returned
 should match the scheme in the `home` option for the site.

 Moving to 4.0 as part of our improvements to SSL support.

 Patch coming up.

 Additionally, #27499 demonstrates where `home` and `siteurl` get polluted
 if this function returns the current scheme rather than the site's actual
 scheme.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/14867#comment:25>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform