[wp-trac] [WordPress Trac] #18791: Add custom post type support for Author Template functions

WordPress Trac noreply at wordpress.org
Thu Jun 5 18:16:06 UTC 2014


#18791: Add custom post type support for Author Template functions
-------------------------+-----------------------
 Reporter:  sirzooro     |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.0
Component:  Users        |     Version:  3.2.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:  template
-------------------------+-----------------------
Changes (by DrewAPicture):

 * keywords:  needs-patch => has-patch
 * milestone:  Awaiting Review => 4.0


Comment:

 While I like the idea of someday being able to add multi support for post
 types here, I think it would be best to tackle that separately. Switching
 to multiple post types would just send us down a rabbit hole in several
 spots, not limited to the cap checks in `get_posts_by_author_sql()`.

 In [attachment:18791.2.patch], I've removed the multiple post types
 support, cleaned up the logic and added the requisite inline docs updates.

 I left in the change to `is_multi_author()` where the `post_type`
 condition was removed, though I'm a little dubious of the effect of that,
 especially since we don't currently have any kind of content definition
 for what does or doesn't have "authors".

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18791#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list