[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

[WordPress Trac]

#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by azaozz):

 > The only 2 things I have an opinion on:
 >
 >  - can we standardize on default being at the bottom?

 Thinking we should. Much easier to read.

 > Sure, but I would rather us be able take advantage of more CI tools now
 and the future which is better for everyone.

 Agreed. Not having unreachable `break;` is "the right way to go". We
 probably should require a comment when the break is missing on purpose
 though, as suggested by @jdgrimes above. `// no break`, `// fall through`,
 anything...

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:88>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform