[wp-trac] [WordPress Trac] #27882: Address some issues found running Scrutinizer

[WordPress Trac]

#27882: Address some issues found running Scrutinizer
----------------------------+-----------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  defect (bug)    |      Status:  reopened
 Priority:  normal          |   Milestone:  4.0
Component:  General         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  needs-patch     |     Focuses:
----------------------------+-----------------------

Comment (by wonderboymusic):

 The only 2 things I have an opinion on:

 1. can we standardize on `default` being at the bottom?
 2. Automation and static analysis are helpful ways for us to examine our
 whole code base. Every single tool complains about `break` after
 `return|exit|die`, whatever. We refactor `switch`s almost never. Is our
 process for code review so broken that a future `case` is guaranteed to
 carelessly  fall through unless we proactively add extraneous `break`s? We
 reopen tickets milliseconds after documentation changes have ambiguous
 grammatical errors. I may be outvoted on this one, but I think this is the
 least of our concerns - conversely, that same argument could have been
 made for me not to remove them in the first place. Sure, but I would
 rather us be able take advantage of more CI tools now and the future which
 is better for everyone.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27882#comment:86>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform