[wp-trac] [WordPress Trac] #29047: upload new media item error style

WordPress Trac noreply at wordpress.org
Wed Jul 30 13:13:00 UTC 2014

#29047: upload new media item error style
 Reporter:  afercia                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  4.0
Component:  Media                    |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui, administration

Comment (by afercia):

 Replying to [comment:5 michalzuber]:
 hi michalzuber,
 you're right again, thx for watching my back :)
 > Changing margin of {{{.wrap div.error}}} might break in
 [http://i.imgur.com/xaXNBiJ.png other views]

 right, messages shown for example on top of "edit post" like "There is an
 autosave of this post..." need that margin. Bit confusing though because
 in common.css {{{div.updated}}} and {{{div.error}}} have a default bottom
 margin of 2px then it's redefined to 15px for the ones inside {{{.wrap}}}.
 I assumed the default was 2px but I was wrong.

 However, when you upload multiple items at once you can get a list with
 "successfully uploaded" items [http://i.imgur.com/FflmwP7.png mixed with
 error messages]. Should errors have margin in this case?

 I'll revert the patch and try to target specifically the errors inside

 > [http://i.imgur.com/EWPt7Ec.png My test question] to the patch:
 > Why is that new error class needed to error-div, it's specific enough I
 think, no need for a new one

 It's the class that gives the "error style" with the left red border and
 some box-shadow. I would like to don't replicate those declarations on
 .error-div and use just the generic .error class. Say in the future you
 want to change the error style, you should be able to do that editing just
 one CSS rule.

Ticket URL: <https://core.trac.wordpress.org/ticket/29047#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list