[wp-trac] [WordPress Trac] #28653: Media: Attachment Display Settings inside Galleries don't work

[WordPress Trac]

#28653: Media: Attachment Display Settings inside Galleries don't work
--------------------------+-----------------------------
 Reporter:  designsimply  |       Owner:  wonderboymusic
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  4.0
Component:  Media         |     Version:  trunk
 Severity:  normal        |  Resolution:  fixed
 Keywords:  needs-patch   |     Focuses:  javascript
--------------------------+-----------------------------
Changes (by wonderboymusic):

 * owner:   => wonderboymusic
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"29285"]:
 {{{
 #!CommitTicketReference repository="" revision="29285"
 Don't render Attachment Display Settings when `display` is set to `false`.
 Currently, the value for `display` in the `media.view.AttachmentsBrowser`
 instance in the `media.view.MediaFrame.Select` frame is set to the value
 for `displaySettings`.
 These values do different things, so check for the existence of `display`
 on the state before arbitrarily setting it to the `displaySettings` value.

 Real world: this hides display settings when you select an image while
 editing a Gallery.

 Fixes #28653.
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28653#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform