[wp-trac] [WordPress Trac] #28934: Remove unneeded div.separator from admin menu

WordPress Trac noreply at wordpress.org
Thu Jul 17 16:52:21 UTC 2014


#28934: Remove unneeded div.separator from admin menu
----------------------------+-----------------------------
 Reporter:  michalzuber     |      Owner:
     Type:  defect (bug)    |     Status:  new
 Priority:  normal          |  Milestone:  Awaiting Review
Component:  General         |    Version:
 Severity:  normal          |   Keywords:
  Focuses:  administration  |
----------------------------+-----------------------------
 I was researching the
 {{{/* @todo: is this even needed given that it's nested beneath the above
 li.wp-menu-separator? */}}}
 {{{
 wordpress-svn$ grep -r 'div.*class=".*separator' src |head
 src/wp-admin/menu-header.php:110:   echo '<div class="separator"></div>';
 }}}

 Is it necessary to have
 {{{
 #adminmenu div.separator {
     height: 2px;
     padding: 0;
 }
 }}}

 The parent <li> has bigger height than that <div>, it is lost there
 {{{
 #adminmenu li.wp-menu-separator {
     height: 5px;
     padding: 0;
     margin: 0 0 6px 0;
     cursor: inherit;
 }
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28934>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list