[wp-trac] [WordPress Trac] #27283: WP_Date_Query missing column user_registered

[WordPress Trac]

#27283: WP_Date_Query missing column user_registered
-----------------------------------------------+---------------------------
 Reporter:  ChriCo                             |       Owner:
     Type:  enhancement                        |      Status:  new
 Priority:  normal                             |   Milestone:  Future
Component:  Query                              |  Release
 Severity:  normal                             |     Version:  3.8
 Keywords:  has-patch commit needs-unit-tests  |  Resolution:
                                               |     Focuses:
-----------------------------------------------+---------------------------
Changes (by nacin):

 * keywords:  has-patch needs-refresh => has-patch commit needs-unit-tests
 * milestone:  4.0 => Future Release


Comment:

 I uploaded a cleaned up patch. Looking at the tests, though, it doesn't
 look like there are any functional assertions here. It's simply comparing
 that the SQL output of a WP_Date_Query instance is returning the same
 WHERE as the WP_Date_Query instance inside WP_User_Query. That's
 insufficient as they could all be returning nothing and the whole thing
 would pass.

 We need to essentially borrow Tests_Comment_DateQuery or
 Tests_Query_DateQuery and make our own Tests_User_DateQuery in
 tests/phpunit/user/datequery.php.

 Moving out of 4.0, though this is simple enough we can bring it back in if
 tests are written.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27283#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform