[wp-trac] [WordPress Trac] #28724: Optimize Regexp Usage in wptexturize()

WordPress Trac noreply at wordpress.org
Sat Jul 5 17:15:31 UTC 2014


#28724: Optimize Regexp Usage in wptexturize()
-------------------------+------------------
 Reporter:  miqrogroove  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.0
Component:  Formatting   |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:
-------------------------+------------------

Comment (by SergeyBiryukov):

 [attachment:miqro-28724-part2.patch] gives me a fatal error:
 {{{
 Fatal error: Can't use function return value in write context in wp-
 includes/formatting.php on line 237
 }}}
 We would need to assign `trim()` to a new variable.

 Is there a reason not to make this check the first in the loop? Can the
 regex can be modified to avoid newlines instead?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/28724#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list