[wp-trac] [WordPress Trac] #28702: using jQuery.on binding for catching the click in custom-header.js
WordPress Trac
noreply at wordpress.org
Wed Jul 2 18:38:04 UTC 2014
#28702: using jQuery.on binding for catching the click in custom-header.js
-----------------------------+-----------------------------
Reporter: DaanMeijer | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch close | Focuses:
-----------------------------+-----------------------------
Changes (by celloexpressions):
* keywords: has-patch => has-patch close
Comment:
I don't see a problem with making this change per se, but I would not
recommend using an admin-specific file that's liable to change and, in
this case, possibly even be removed (see #25571), in a theme or plugin.
And this change isn't necessary for this file to function as intended for
core.
If you want similar functionality to what that file does, copy it into a
new, appropriately named file bundled with your theme/plugin and tweak it
to fit your needs. Or, look at a tutorial on using the media library in
themes and plugins. Also, you shouldn't use an id like that in a widget,
as multiple instances of the widget will result in duplicate ids.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/28702#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list