[wp-trac] [WordPress Trac] #23587: url_to_postid() needs to use # or @ for preg_match start/end character

WordPress Trac noreply at wordpress.org
Fri Jan 31 18:09:51 UTC 2014


#23587: url_to_postid() needs to use # or @ for preg_match start/end character
------------------------------+--------------------
 Reporter:  coreygilmore      |       Owner:
     Type:  defect (bug)      |      Status:  new
 Priority:  normal            |   Milestone:  3.9
Component:  Rewrite Rules     |     Version:  1.5.2
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:
------------------------------+--------------------
Changes (by nacin):

 * keywords:  has-patch => has-patch commit
 * milestone:  Future Release => 3.9


Comment:

 [attachment:23587_regex_delimiters.patch] looks OK to me. Is this
 something we could unit test?

 What if someone wrongly includes '#' in an existing rewrite rule? What
 happens currently? If it has minimal side effects currently, switching to
 an E_WARNING doesn't sound very nice. See also #12271.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/23587#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list