[wp-trac] [WordPress Trac] #25560: Update to PHPMailer 5.2.7

[WordPress Trac]

#25560: Update to PHPMailer 5.2.7
---------------------------------+------------------
 Reporter:  MattyRob             |       Owner:
     Type:  enhancement          |      Status:  new
 Priority:  normal               |   Milestone:  3.9
Component:  External Libraries   |     Version:  3.7
 Severity:  normal               |  Resolution:
 Keywords:  3.9-early has-patch  |     Focuses:
---------------------------------+------------------

Comment (by nacin):

 I don't mind moving files around if it makes sense. And, really, fine with
 LICENSE if we move it to a directory.

 The problem with autoloading is that SPL can still be disabled in PHP 5.2,
 and considering we've seen installs with '''hash''' disabled, I'm not
 liking our chances of this blowing up some sites. This would be the first
 usage of SPL in core — we don't use any classes, interfaces, or functions
 currently. The closest we get is ArrayAccess, which is a non-SPL interface
 that ArrayObject implements.

 I doubt they will accept a PR to remove the autoloader check because it
 would be trivial to subclass PHPMailer and just not call the parent
 constructor. It seems forced to me, what they're doing, but I guess it is
 for backwards compatibility reasons, so I can only complain so much. So we
 may just need to remove those lines. Considering it is basically the
 entire constructor, this is not (yet) difficult to maintain. It'd be our
 only hack, and because if it accidentally slips back in during a future
 update to the library, it'd fatal error in testing.

 So if we don't ship the autoloader, we're back down to the same two files
 we already have. And since they're no longer requiring class.smtp.php, we
 no longer need to hack it up for the purposes of hyphens. Though I guess
 we'll need to add a require line to the constructor.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25560#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform