[wp-trac] [WordPress Trac] #26397: Hook Docs (16): wp-admin/includes/class-wp-posts-list-table.php

[WordPress Trac]

#26397: Hook Docs (16): wp-admin/includes/class-wp-posts-list-table.php
---------------------------------------+------------------------------
 Reporter:  nicolealleyinteractivecom  |       Owner:  kpdesign
     Type:  defect (bug)               |      Status:  assigned
 Priority:  normal                     |   Milestone:  Awaiting Review
Component:  Post Types                 |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch                |     Focuses:  docs
---------------------------------------+------------------------------
Changes (by DrewAPicture):

 * keywords:  has-patch => needs-patch
 * reporter:  nicole@… => nicolealleyinteractivecom


Comment:

 Hi, thanks for the patch. Looks pretty good, just a couple of things:

 `restrict_manage_posts` hook:
 * Need specificity on what kind of list table this would fire in (hint, it
 fires two different list tables!)

 `manage_taxonomies_for_$post_type_columns` filter:
 * Short description needs a period, as do the parameter descriptions.

 `page_row_actions` filter:
 * You should probably mention that the hook name changes based no whether
 the current post type is hierarchical (pages) or not (posts).
 * Parameter doc is missing for `$post`

 `post_date_column_time` filter:
 * There's an extra space before the period in the short description.
 * The first parameter doc doesn't match, maybe a copy/pasta issue.

 `manage_pages_custom_column`, `manage_posts_custom_column`, and
 `manage_{$post->post_type}_posts_custom_column` hooks:
 * You should use a docs-specific variable for the parameter lines. So
 instead of `$post->ID`, maybe just use `$post_id`

 `quick_edit_dropdown_pages_args` filter:
 * Need an `@see` tag between the `@since` and first `@param` tags pointing
 to `wp_dropdown_pages()`

 `bulk_edit_custom_box`/`quick_edit_custom_box` hooks:
 * The description should reflect that it could fire for either or of the
 two different hooks depending on the circumstance.
 * Use a docs-specific variable for the second parameter here. Perhaps
 `$post_type`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26397#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform