[wp-trac] [WordPress Trac] #26887: Make wpdb::base_prefix explicitly public
WordPress Trac
noreply at wordpress.org
Wed Jan 29 00:37:39 UTC 2014
#26887: Make wpdb::base_prefix explicitly public
---------------------------+------------------------------
Reporter: DavidAnderson | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Database | Version:
Severity: normal | Resolution:
Keywords: | Focuses:
---------------------------+------------------------------
Comment (by nacin):
Replying to [comment:1 DavidAnderson]:
> Please disregard the first patch. Did the trac feature to replace a
patch disappear? I couldn't see it.
Yeah, it's been removed. It was too often used improperly, this
overwriting previous work and making it tougher to follow progress on a
ticket.
Could you explain the switch from isset() to !empty()? I don't see
anything about that in your bug report.
I'm not against this, but we should then use the public visibility
keyword.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/26887#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list