[wp-trac] [WordPress Trac] #26829: Use of strpos() in extract_from_markers() and insert_with_markers() can target wrong BEGIN and END markers.

[WordPress Trac]

#26829: Use of strpos() in extract_from_markers() and insert_with_markers() can
target wrong BEGIN and END markers.
--------------------------------------+------------------------------
 Reporter:  Faison                    |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  Awaiting Review
Component:  Rewrite Rules             |     Version:  trunk
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:
--------------------------------------+------------------------------
Changes (by Faison):

 * keywords:  has-patch needs-unit-tests => has-patch has-unit-tests


Comment:

 Hi Nacin,

 Looked like you were busy with 3.8.1 and the other core initiatives, so I
 went ahead and wrote unit tests and updated my patch to allow for mocking
 of the WP_Filesystem_Direct object.

 Thanks,
 Faison

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26829#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform