[wp-trac] [WordPress Trac] #26929: add_site_option signature should match add_option signature

[WordPress Trac]

#26929: add_site_option signature should match add_option signature
------------------------------+------------------------------
 Reporter:  ChrisWiegman      |       Owner:
     Type:  enhancement       |      Status:  new
 Priority:  normal            |   Milestone:  Awaiting Review
Component:  Options and Meta  |     Version:  3.8
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:  multisite
------------------------------+------------------------------
Changes (by jeremyfelt):

 * focuses:   => multisite


Comment:

 Hi @ChrisWiegman, thanks for the patch.

 `add_site_option` stores data in the `$wpdb->sitemeta` table if the
 installation is multisite, and stores data via `add_option()` in
 `$wpdb->options` if not.

 A hard part of adding an autoload flag to `add_site_option()` would be its
 usefulness only for single site installations. The extra parameter may
 cause confusion for developers working on a primarily multisite function.

 I wonder if `$wpdb->options` is the right place for an option requiring
 autoload anyway.

 If we did add this parameter, I think the current patch's inclusion of
 `add_option()`'s deprecated parameter in `add_site_option()` is
 unnecessary.

 Related #22846

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26929#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform