[wp-trac] [WordPress Trac] #25604: first argument of wpdb::prepare should have a placeholder

[WordPress Trac]

#25604: first argument of wpdb::prepare should have a placeholder
-------------------------------------+------------------
 Reporter:  ounziw                   |       Owner:
     Type:  enhancement              |      Status:  new
 Priority:  normal                   |   Milestone:  3.9
Component:  Database                 |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-refresh  |     Focuses:
-------------------------------------+------------------
Changes (by nacin):

 * keywords:   => has-patch needs-refresh
 * component:  Warnings/Notices => Database
 * milestone:  Awaiting Review => 3.9


Comment:

 Looking good. This patch needs to be updated a bit. Namely:
  * Whitespace inside strpos() parentheses and after the comma to match our
 coding standards.
  * The string should probably be translated by being wrapped in the `__()`
 function.
  * Braces should be used for this if conditional (recent coding standards
 change).
  * Version number will need to be updated to 3.9.
  * `__METHOD__` can be used in lieu of 'wpdb::prepare'.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25604#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform