[wp-trac] [WordPress Trac] #26879: Hello, new users. Here is an Error.
WordPress Trac
noreply at wordpress.org
Mon Jan 20 18:57:25 UTC 2014
#26879: Hello, new users. Here is an Error.
--------------------------------------------------+------------------
Reporter: mrtortai | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.9
Component: Upgrade/Install | Version: 3.0
Severity: normal | Resolution:
Keywords: good-first-bug has-patch 2nd-opinion |
--------------------------------------------------+------------------
Changes (by nacin):
* milestone: Awaiting Review => 3.9
Comment:
Going to take this off the good-first-bug report as mrtortai is already on
it. :-)
I think this is a great improvement! There are some things I'd probably
change. Here's a rundown.
1. I'd drop the version number. It isn't important. Let's just invite
them to WordPress. I like my Howdy's and emoticons, but I'd probably
simplify the title to just "Welcome to WordPress!" (Same for <title>).
2. The widow ("imagine" on its own line) is killing me. I'm wondering
regardless if we can merge the first two paragraphs (or perhaps all
three). Or, we need to change something like widths or padding.
3. wp_die() is a generic function used for a lot of error messages. I
don't think we need to change #error-page to #wp-welcome-page. It would be
nice, but it's not necessary and this is really the rare situation where
it's not an error, not the standard use case.
4. The same thought applies to the WordPress logo. We don't need to
overly imply ownership or responsibility over an error message — it's
better to not put the logo on them. We can pass this logo directly into
wp_die() (and leave the CSS in wp_die() for when it is passed) for this
one situation.
5. We probably still need to include some kind of help information
regarding wp-config.php. There's a link to the Codex there, for example, a
poorly-worded explanation that it doesn't always work, etc.
6. I'd also try to ditch the border/underline below the h1. After the
next pass, though, I'll ask a designer to look at it.
7. There's no need to patch minified files. That gets handled on build.
There's also no need to patch RTL files. Those are also generated
automatically on build. See also the *other* repository,
http://develop.svn.wordpress.org/trunk, and the Grunt tasks there.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/26879#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list