[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General

[WordPress Trac]

#16434: Give site admin ability to upload favicon in Settings, General
-------------------------------------+-----------------------------
 Reporter:  jane                     |       Owner:
     Type:  feature request          |      Status:  new
 Priority:  normal                   |   Milestone:  Future Release
Component:  Administration           |     Version:  3.1
 Severity:  normal                   |  Resolution:
 Keywords:  ux-feedback needs-patch  |
-------------------------------------+-----------------------------
Changes (by celloexpressions):

 * keywords:  has-patch needs-testing ux-feedback => ux-feedback needs-patch


Comment:

 IE11 supports PNGs for favicons, so we no longer need to worry about
 creating ICOs. Because IE8 is approaching EOL (techinically WinXP is, but
 that's the only reason to still run IE8, and that happens a week before
 when WordPress 3.9 is planned for), and IE9 and 10 auto-update (albeit
 very slowly and not in all installations), I don't think we need to worry
 too much about older versions long-term. Even if this feature were
 launched today, it would work for well over 80% of users with only PNGs,
 and that number's going to keep going up (probably rapidly).

 I don't think this project necessitates a feature plugin; it's pretty
 straightforward without the ICO part. Maybe an IRC meeting to nail down
 the implementation. I think we could take the following simplified
 approach for a long-overdue first-pass:

 - Upload button in Settings->general. No need for media library
 integration, since pictures and content-type images aren't generally
 appropriate.
 - On upload, resize and crop down to 32px square (via functions enhanced
 in 3.5). I see no reason for a crop UI (32px displayed as 16px is too
 tiny); if the user wants a different crop that can be done outside of
 WordPress, or we could add that in a future iteration.
 - If the user uploads an ICO file, use it directly.
 - Once a favicon has been uploaded, display it on Settings->General with
 an "upload new favicon" button and a remove link.
 - Bonus: duplicate this UI in the customizer, next to the site title &
 tagline options there.
 - Perhaps we should consider NOT saving the image as an attachment, and
 rather just saving its url in `wp_options`. Favicons are fundamentally
 different than everything else the media library is used for, and worst-
 case scenario the user re-uploads the image if they want to add it to a
 post, as a header image, etc.
 - Plugins and hooks: if we also save the location of the originally
 uploaded image, plugins can access that image and create additional sizes
 for proprietory OS-specific icons (for example, iOS icons and Windows 8
 tiles). We can also add hooks in the upload process, so that custom sizes
 can be created and handled at the same time.
 I think a big reason this still hasn't happened is that it became too
 complicated for a first-pass. Let's approach it bit by bit; we could even
 potentially get multiple iterations into the same release. I don't think
 this is nearly as complex of a feature as some of the patches on this
 ticket make it.

 We probably need to look at a fresh approach, given the age of the
 existing discussion & patches.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/16434#comment:136>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform