[wp-trac] [WordPress Trac] #26628: Use the content of a video shortcode when provided

WordPress Trac noreply at wordpress.org
Tue Jan 14 22:05:05 UTC 2014


#26628: Use the content of a video shortcode when provided
----------------------------+------------------
 Reporter:  wonderboymusic  |       Owner:
     Type:  enhancement     |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Media           |     Version:  3.6
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------

Comment (by azaozz):

 Was about to say there's no reason dashicons cannot be added to the
 editor, but you added it in 26628.2.diff :)

 Looking at the TinyMCE plugin, the regexps can be simplified a bit and the
 name should start with `wp` like the other custom WordPress plugins (will
 change that on commit).

 Also it triggered a bug with `send_to_editor()`: we preemptively replace
 the shortcodes with the html there which is not needed any more. The bug
 is that the regex can still find the shortcode string inside the title
 attr. and process it on `editor.on( 'BeforeSetContent', ... )`, so it ends
 up quite broken. Will fix that first.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26628#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list