[wp-trac] [WordPress Trac] #26823: wp_get_image_editor->multi_resize()
WordPress Trac
noreply at wordpress.org
Mon Jan 13 21:57:47 UTC 2014
#26823: wp_get_image_editor->multi_resize()
--------------------------+------------------------------
Reporter: pbearne | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Inline Docs | Version: 3.5
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------------------
Comment (by pbearne):
Replying to [comment:8 markoheijnen]:
> I dislike the need of PHP_INT_MAX. I think that should be difference
since image_resize_dimensions can handle it.
I agree that it would nice if that function handled the NULL's
I read through the code and couldn't workout how it would handle NULL's
being passed in and the comments only refer to INT :-)
I could set 9999 or some other random number but this could fail in an
edge case so I felt that PHP_INT_MAX was the best as if the image is that
big than that something else would break first
Paul
--
Ticket URL: <https://core.trac.wordpress.org/ticket/26823#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list