[wp-trac] [WordPress Trac] #26823: wp_get_image_editor->multi_resize()

[WordPress Trac]

#26823: wp_get_image_editor->multi_resize()
-------------------------------------------+------------------------------
 Reporter:  pbearne                        |       Owner:
     Type:  defect (bug)                   |      Status:  new
 Priority:  normal                         |   Milestone:  Awaiting Review
Component:  Inline Docs                    |     Version:  3.5
 Severity:  normal                         |  Resolution:
 Keywords:  needs-patch reporter-feedback  |
-------------------------------------------+------------------------------
Changes (by DH-Shredder):

 * keywords:  has-patch => needs-patch reporter-feedback
 * version:  trunk => 3.5
 * component:  External Libraries => Inline Docs


Comment:

 Thanks for the ticket and patch!

 You are correct in that `width` and `height` can't both be set to null,
 but current code does support one or the other set to null, so that the
 image is auto-sized according to its current ratio.

 This is handled within [https://core.trac.wordpress.org/browser/trunk/src
 /wp-includes/media.php#L320 image_resize_dimensions], and we could
 absolutely benefit from improved documentation both within the base
 WP_Image_Editor and extending (GD/Imagick) classes for clarification.

 I'd suggest taking a look at the [http://make.wordpress.org/core/handbook
 /inline-documentation-standards/php-documentation-standards/#phpdoc-block-
 formatting inline documentation standards] for a few pointers on style for
 comments within core.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26823#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform