[wp-trac] [WordPress Trac] #25560: Update to PHPMailer 5.2.7

[WordPress Trac]

#25560: Update to PHPMailer 5.2.7
---------------------------------+------------------
 Reporter:  MattyRob             |       Owner:
     Type:  enhancement          |      Status:  new
 Priority:  normal               |   Milestone:  3.9
Component:  External Libraries   |     Version:  3.7
 Severity:  normal               |  Resolution:
 Keywords:  3.9-early has-patch  |
---------------------------------+------------------
Changes (by bpetty):

 * milestone:  Future Release => 3.9


Comment:

 I'm guessing you generated that last patch from Windows since all your
 files are set as executable (or you just have really wrong autoprops
 configured). Also, assuming the intention was to include the entire
 release, you're still missing a bunch of files from the official package
 (and not just binary image files):

 {{{
  src/wp-includes/PHPMailer/.gitignore                         |    4 +
  src/wp-includes/PHPMailer/.travis.yml                        |   20 +
  src/wp-includes/PHPMailer/composer.json                      |   33 +
  src/wp-includes/PHPMailer/docs/Callback_function_notes.txt   |   17 +
  src/wp-includes/PHPMailer/docs/DomainKeys_notes.txt          |   55 ++
  src/wp-includes/PHPMailer/docs/Note_for_SMTP_debugging.txt   |   17 +
  src/wp-includes/PHPMailer/docs/extending.html                |  145 +++
  src/wp-includes/PHPMailer/docs/faq.html                      |   67 ++
  src/wp-includes/PHPMailer/docs/generatedocs.sh               |    5 +
  src/wp-includes/PHPMailer/docs/pop3_article.txt              |   50 ++
  src/wp-includes/PHPMailer/examples/images/phpmailer.png      |  Bin 0 ->
 8670 bytes
  src/wp-includes/PHPMailer/examples/images/phpmailer_mini.gif |  Bin 0 ->
 1042 bytes
  src/wp-includes/PHPMailer/examples/scripts/XRegExp.js        |    0
  src/wp-includes/PHPMailer/examples/styles/wrapping.png       |  Bin 0 ->
 631 bytes
  src/wp-includes/PHPMailer/extras/EasyPeasyICS.php            |   90 ++
  src/wp-includes/PHPMailer/extras/class.html2text.php         |  696
 +++++++++++++++
  src/wp-includes/PHPMailer/extras/htmlfilter.php              |  861
 ++++++++++++++++++
  src/wp-includes/PHPMailer/extras/ntlm_sasl_client.php        |  185 ++++
  src/wp-includes/PHPMailer/test/fakepopserver.sh              |  125 +++
  src/wp-includes/PHPMailer/test/fakesendmail.sh               |   22 +
  src/wp-includes/PHPMailer/test/phpmailerLangTest.php         |  340
 ++++++++
  src/wp-includes/PHPMailer/test/phpmailerTest.php             | 1402
 ++++++++++++++++++++++++++++++
  src/wp-includes/PHPMailer/test/runfakepopserver.sh           |   10 +
  src/wp-includes/PHPMailer/test/test_callback.php             |   82 ++
  src/wp-includes/PHPMailer/test/testbootstrap-dist.php        |    7 +
  25 files changed, 4233 insertions(+)
 }}}

 I'm starting to wonder if it's still a good idea to distribute the entire
 release now though. It's 836K in total, but if we exclude the docs, tests,
 and especially the examples, it drops 416K of that. Additionally, it's not
 a direct security vulnerability, but I feel a little safer not including
 all of the utility shell scripts found in all 3 of those folders.

 I've taken this opportunity to also actually clear out the old PHPMailer
 code in `class-phpmailer.php` and `class-smtp.php`, and replace them with
 backwards compatible shim includes pulling in the code in the new
 location.

 I've also updated the `MockPHPMailer` class in the unit tests with the
 really minor changes upstream in PHPMailer (they apparently decided
 methods shouldn't be capitalized).

 I'm including two versions of this patch for review:

 - [attachment:ticket-25560-phpmailer-full-binary.patch]: This is the full
 PHPMailer release including images, in the form of a binary patch (can
 only be applied with `git apply`).
 - [attachment:ticket-25560-phpmailer-minimal.patch]: Same as above, but
 with the following directories not included: `docs`, `examples`, and
 `test`. Doesn't require `git apply` since there's no images included.

--
Ticket URL: <http://core.trac.wordpress.org/ticket/25560#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software