[wp-trac] [WordPress Trac] #21876: unregister_default_headers() will sometimes return null

WordPress Trac noreply at wordpress.org
Fri Feb 28 01:09:07 UTC 2014


#21876: unregister_default_headers() will sometimes return null
------------------------------------+--------------------
 Reporter:  conner_bw               |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  3.9
Component:  Appearance              |     Version:  3.4.2
 Severity:  minor                   |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+--------------------

Comment (by SergeyBiryukov):

 Replying to [comment:6 obenland]:
 > What is gained by having the function return `true` as soon as we have
 one successful removal of a number of header to be removed? Would you want
 the function to return true if one header was removed, but the other 5
 that you passed weren't?

 Unless I'm missing something, the patch should only return true if all the
 headers were removed.

 [attachment:21876.4.diff] was my initial thought as well, but
 [attachment:21876.3.diff] seemed a bit less cryptic.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21876#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list