[wp-trac] [WordPress Trac] #21785: Add header image uploads with cropping to the customizer

[WordPress Trac]

#21785: Add header image uploads with cropping to the customizer
----------------------------+-----------------------------
 Reporter:  nacin           |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  Future Release
Component:  Appearance      |     Version:  3.4
 Severity:  normal          |  Resolution:
 Keywords:                  |     Focuses:  javascript
----------------------------+-----------------------------

Comment (by mcsf):

 Updated patches
 [https://core.trac.wordpress.org/attachment/ticket/21785/21785-media-
 manager.2.diff 21785-media-manager.2.diff],
 [https://core.trac.wordpress.org/attachment/ticket/21785/21785-customize-
 header.2.diff 21785-customize-header.2.diff] and
 [https://core.trac.wordpress.org/attachment/ticket/21785/21785-tests.2.diff
 21785-tests.2.diff] address feedback from @nacin and @ocean90, namely:

 * Replaced image (the "close" PNG) with Dashicon
 * Ditched slimScroll

 * AJAX: Added missing capabilities check
 * AJAX: action adds alternatively use `$this` and `__CLASS__`

 * L10n: Added missing l10n for "No image set" placeholder
 * CSS: Removed wpcom-ism (`body:not(.blue)`)

 * JS: Moved Header views and models from `wp-admin` to `wp-includes`
 * JS: Ditched the template in `wp.media.view.Cropper`

 * PHP: In `WP_Customize_Header_Image_Control::render_content`: braces
 around if and else blocks.
 * PHP: Use `wp_die` over `die`

 * Tests: have test classes extend `WP_UnitTestCase`
 * Tests: Move JS test fixtures to `index.html`
 * Check that JSHint rules are followed

 * (not from feedback) Cleanup: Removed leftover parent attachment logic
 from previous feature

 For reference, we're doing development at [https://github.com/ehg
 /wordpress-develop/ github:ehg/wordpress-develop]; use
 `/commits/dev?author=AUTHOR` with `AUTHOR` in `(ehg|mcsf)` for granular
 commits.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/21785#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform