[wp-trac] [WordPress Trac] #27198: Improve pushState/hashChange routing in Appearance > Themes
WordPress Trac
noreply at wordpress.org
Tue Feb 25 18:46:03 UTC 2014
#27198: Improve pushState/hashChange routing in Appearance > Themes
-------------------------+-------------------------
Reporter: gcorne | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.9
Component: Themes | Version: 3.8.1
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript
-------------------------+-------------------------
Comment (by adamsilverstein):
Replying to [comment:4 gcorne]:
> [attachment:27198-03.patch 27198-03.patch] addresses the following
feedback from markjaquith:
>
> * Searching and then clicking the back button, and then searching again
should reset {{{this.searching}}} so that we pushSate instead of
replaceState when searching again
> * Clearing a search should pushState instead of replaceState
>
> Also, uses correct {{{keyCode}}} for {{{enter}}}.
Looks good to me, 13 makes more sense than 15 :)
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27198#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list