[wp-trac] [WordPress Trac] #21663: Use PDO or mysqli for MySQL queries when available
WordPress Trac
noreply at wordpress.org
Tue Feb 25 16:11:12 UTC 2014
#21663: Use PDO or mysqli for MySQL queries when available
------------------------------+------------------
Reporter: scottconnerly | Owner:
Type: task (blessed) | Status: new
Priority: normal | Milestone: 3.9
Component: Database | Version: 3.5
Severity: normal | Resolution:
Keywords: has-patch commit | Focuses:
------------------------------+------------------
Comment (by Denis-de-Bernardy):
Replying to [comment:195 nacin]:
> [attachment:21663.13.diff] adds a constant called USE_EXT_MYSQL. Rather
than the more forward-thinking driver approach, this simply restricts it
to applying to the enabling/disabling of ext/mysql.
{{{
$this->use_mysqli = (bool) USE_EXT_MYSQL;
}}}
I think you meant:
{{{
$this->use_mysqli = !USE_EXT_MYSQL;
}}}
That said, methinks the define should actually be `USE_EXT_MYSQLI` to
*enable* MySQLi, rather than `USE_EXT_MYSQL` to *disable* MySQL.
Imho, the odds are ridiculously low that someone would actually go in his
wp-config file and define a constant to use the clunky old library,
whereas I can readily imagine a number of hackers going in there and
happily define a constant that allows to use the more modern library.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/21663#comment:197>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list