[wp-trac] [WordPress Trac] #26952: Style TinyMCE modals to match WordPress admin styling

WordPress Trac noreply at wordpress.org
Mon Feb 24 22:50:01 UTC 2014


#26952: Style TinyMCE modals to match WordPress admin styling
--------------------------+--------------------
 Reporter:  melchoyce     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.9
Component:  TinyMCE       |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  ui
--------------------------+--------------------

Comment (by alleynoah):

 In changeset [27190], the use of `!important` in the modal's `z-index`
 styling (for example, https://core.trac.wordpress.org/browser/trunk/src
 /wp-includes/css/editor.css#L24) to override TinyMCE's use of inline
 `z-index` styling causes problems -- if there are additional modal
 elements, they appear behind the overridden modal and mask. This breaks
 some elements of the TinyMCE4 table plugin for example (I'll attach a
 screenshot below). I know it mirrors the media modal styles, but is it
 necessary to override the z-index this way? On my instance if I simply
 disabled those overrides I didn't notice any issues, but there certainly
 may be cases that I'm not thinking of.

 I'll also attach a patch that solves the problem for me in the opposite
 direction (just by adding a similar override to the menu element). My
 concern about the "more overrides" direction is just that it could
 potentially mean adding overrides for every special case where TinyMCE
 already has the handling built, and might make using TinyMCE4 plugins more
 complex.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/26952#comment:30>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list