[wp-trac] [WordPress Trac] #27196: More informative message when plugin installs fail (patch attached)

[WordPress Trac]

#27196: More informative message when plugin installs fail (patch attached)
------------------------------------+------------------------------
 Reporter:  DavidAnderson           |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  Upgrade/Install         |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  administration
------------------------------------+------------------------------
Changes (by adamsilverstein):

 * keywords:  has-patch => has-patch dev-feedback
 * focuses:   => administration


Comment:

 Replying to [comment:1 DavidAnderson]:

 David,

 Thanks for your patch! It makes sense to provide better error messages, I
 can only imagine your frustration support end users of your plugin with
 the same issue over and over again.

 I refreshed your patch in [attachment:27196.diff]:
  * added spacing throughout as per the
 [http://make.wordpress.org/core/handbook/coding-standards/php/ WordPress
 PHP Coding standards]
 * adjusted error message language to make tense match other messages
 * removed the @ in front of in_array (what output are we suppressing
 here?)

 Otherwise looks good to me, although I haven't tested directly to make
 sure it works as expected. Have you done that? A screencast or screenshots
 would be helpful here (showing the error message, before and after the
 patch), even better would be a unit test if its even possible to simulate
 this type of issue with the unit testing framework. (I'm not really sure
 how to approach that)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27196#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform