[wp-trac] [WordPress Trac] #27188: deactived_plugin behaves improperly
WordPress Trac
noreply at wordpress.org
Sun Feb 23 15:58:02 UTC 2014
#27188: deactived_plugin behaves improperly
--------------------------+--------------------
Reporter: wpsmith | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.9
Component: Plugins | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
--------------------------+--------------------
Comment (by wpsmith):
Replying to [comment:2 ocean90]:
> Option 1 seems ok. I would also move `'deactivate_' . $plugin` and
`deactivate_plugin` together.
I don't think they should be moved together. The tense of `'deactivate_'
. $plugin` suggests that it is in the middle of deactivating the current
plugin or is not yet complete in the deactivation process. It is where the
current plugin being deactivated hooks to run it's deactivating process,
function, or method. The later, `'deactivated_plugin'`, suggests that the
plugin has already been deactivated. To me, these are two different steps
in the process, even thou a deactivated plugin is only an option in the
WordPress database.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27188#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list