[wp-trac] [WordPress Trac] #22115: Further Simplifying errors
WordPress Trac
noreply at wordpress.org
Sat Feb 22 20:21:11 UTC 2014
#22115: Further Simplifying errors
-------------------------+-----------------------------
Reporter: msolution | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Future Release
Component: Database | Version: 3.4.2
Severity: normal | Resolution:
Keywords: has-patch | Focuses:
-------------------------+-----------------------------
Changes (by bpetty):
* keywords: 2nd-opinion dev-feedback has-patch => has-patch
Comment:
A good amount of code has changed in WPDB since the original patch here.
I've refreshed the patch, though note that I still leave the call to
`print_error()` in the same place rather than moving it up. This is mostly
since WPDB now automatically tries to reconnect to the DB if the
connection is lost - something that didn't happen when this patch was
originally submitted.
I tested this briefly with bad queries and the Debug Bar plugin installed
with `SAVEQUERIES` defined, and while Debug Bar doesn't use this extra
value, I still wanted to make sure it didn't throw it off that it was
there. It still works smoothly.
So I think this is still a good patch.
Note that this will need to be refreshed again if/when #21663 is applied
to account for MySQLi.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/22115#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list