[wp-trac] [WordPress Trac] #12506: Standalone login styles
WordPress Trac
noreply at wordpress.org
Fri Feb 21 12:46:37 UTC 2014
#12506: Standalone login styles
------------------------------------+-----------------------
Reporter: F J Kaiser | Owner: helen
Type: enhancement | Status: accepted
Priority: low | Milestone: 3.9
Component: Login and Registration | Version: 2.9.2
Severity: minor | Resolution:
Keywords: has-patch | Focuses: ui
------------------------------------+-----------------------
Comment (by F J Kaiser):
Nice to see progress.
Replying to [comment:34 helen]:
> I did not change the current selectors for login styling - I'm not sure
we really need to or should, but open to more discussion.
There are quite some inconsistencies in the generated MarkUp by `wp-
login.php`, which we should prepare to remove. Example:
{{{
echo '<div id="login_error">' . apply_filters( 'login_errors', $errors ) .
"</div>\n";
echo '<p class="message">' . apply_filters( 'login_messages', $messages )
. "</p>\n";
}}}
IDs vs. classes or assuming one vs. many.
The naming scheme in place is equally inconsistent, see those examples for
"password":
{{{
<form id="lostpasswordform"
<form id="resetpassform"
<p class="message reset-pass">
<input type="password" name="pass1" id="pass1"
<input type="password" name="pass2" id="pass2"
<div id="pass-strength-result"
<p id="reg_passmail">
<input type="password" name="pwd" id="user_pass"
}}}
We should really try to introduce parallel classes to allow us to mark all
the inconsistent stuff to be marked as deprecated.
And we should think about a prefix that allows us to consistently
determine which action we're currently targeting.
* {{{password--lost__*}}}
* {{{password--reset__*}}}
* {{{login__*}}}
* {{{register__*}}}
At least this ticket would offer us a good chance.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/12506#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list