[wp-trac] [WordPress Trac] #27109: Wrong $parent_file value in wp-admin/update-core.php

[WordPress Trac]

#27109: Wrong $parent_file value in wp-admin/update-core.php
---------------------------------------------+-----------------------------
 Reporter:  SergeyBiryukov                   |       Owner:
     Type:  defect (bug)                     |      Status:  new
 Priority:  normal                           |   Milestone:  3.9
Component:  Upgrade/Install                  |     Version:  3.0
 Severity:  trivial                          |  Resolution:
 Keywords:  good-first-bug has-patch commit  |     Focuses:  administration
---------------------------------------------+-----------------------------
Changes (by SergeyBiryukov):

 * keywords:  good-first-bug => good-first-bug has-patch commit
 * severity:  normal => trivial
 * milestone:  Awaiting Review => 3.9


Old description:

> When Updates menu item was moved from Tools to Dashboard in [13588],
> `$parent_file` was not updated: [source:tags/3.8.1/src/wp-admin/update-
> core.php#L459].
>
> `get_admin_page_parent()` correctly overrides it with `index.php`. This
> leaves me wondering if the explicit declaration is actually necessary,
> but have it on other admin screens as well, so let's just update it.

New description:

 When Updates menu item was moved from Tools to Dashboard in [13588],
 `$parent_file` was not updated: [source:tags/3.8.1/src/wp-admin/update-
 core.php#L459].

 `get_admin_page_parent()` correctly overrides it with `index.php`. This
 leaves me wondering if the explicit declaration is actually necessary, but
 we have it on other admin screens as well, so let's just update it.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27109#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform