[wp-trac] [WordPress Trac] #26669: wp-admin.css should be broken up into modules
WordPress Trac
noreply at wordpress.org
Wed Feb 19 22:01:06 UTC 2014
#26669: wp-admin.css should be broken up into modules
----------------------------+---------------------
Reporter: jorbin | Owner: helen
Type: enhancement | Status: closed
Priority: normal | Milestone: 3.9
Component: Administration | Version:
Severity: normal | Resolution: fixed
Keywords: has-patch | Focuses: ui
----------------------------+---------------------
Changes (by helen):
* milestone: Awaiting Review => 3.9
Comment:
A few things here:
1. Do not attempt to load the changeset in Trac or link to it directly. At
last count, the number of altered lines was 213,216, due to using `svn cp`
to create each of the new CSS files with history.
2. `wp-admin.css` uses `@import` for each of the
modules/components/whatever we call them, cssjanus creates RTL versions of
each, and `wp-admin-rtl.css` is created, calling the generated RTL files.
3. The hit of multiple HTTP requests only applies with `SCRIPT_DEBUG` on -
`clean-css` (via `cssmin`) inlines `@import`ed files in the minified
versions.
4. This approach works out well for us because it does not involve script
loader changes, it utilizes existing tooling, `core.svn` and `develop.svn`
can continue to both be used for patches, and web inspectors handle CSS
`@import`s already - no need to worry about whether or not source maps are
supported yet.
Please open new tickets for any issues discovered, as it may not be clear
whether it is a consequence of this split or the preceding colors.css
merge in #18380.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/26669#comment:18>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list