[wp-trac] [WordPress Trac] #25169: Optimize all images / pngs in core
WordPress Trac
noreply at wordpress.org
Wed Feb 19 01:00:22 UTC 2014
#25169: Optimize all images / pngs in core
------------------------------------+--------------------------------------
Reporter: bradparbs | Owner: nacin
Type: enhancement | Status: reopened
Priority: normal | Milestone: 3.9
Component: Build/Test Tools | Version:
Severity: normal | Resolution:
Keywords: has-patch commit close | Focuses: javascript, performance
------------------------------------+--------------------------------------
Comment (by jorbin):
> However I'm 50/50 on whether this should be running automatically on
each build. We are up to 46MB! of build tools (node_modules), 7,428 files
in 1,699 directories... The chances for failed updates, platform specific
bugs, local and platform differences, different output because of
different version of the build tools, etc. are quite high. Our build
process shouldn't be "fragile".
>
> Considering that new images are added to core only a few times per
cycle, seems this can be a "manual" task, i.e. should be run with grunt
imagemin only when needed.
I completely agree that our build process shouldn't be fragile. It also
shouldn't require much cognitive load or knowledge to run. Yes, updating
images is not a common tasks, but you shouldn't need to think "Well I'm
adding images, so I need to run this task, but I'm also modifying CSS, so
I need to run this other task". By including all front end tasks that we
expect to be run before a commit into one task, we reduce the cognitive
load on developers and require them to only run one task.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/25169#comment:20>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list