[wp-trac] [WordPress Trac] #27122: Optimization for PHP FPM

[WordPress Trac]

#27122: Optimization for PHP FPM
-------------------------+------------------------------
 Reporter:  dunglas      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  General      |     Version:  3.8
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:  performance
-------------------------+------------------------------

Comment (by Denis-de-Bernardy):

 Replying to [comment:10 dunglas]:
 > This new patch ({{{ shutdown_flush.diff }}}) includes @Denis-de-Bernardy
 improvements but calls {{{ wp_ob_end_flush_all() }}} only if necessary.

 I think you're misunderstanding or misinterpreting what
 `wp_ob_end_flush_all()` was initially about.

 The function was introduced due to a change in the way PHP handles object
 destruction around 5.1 or 5.2: global variables that were garbage
 collected after all code had run suddenly began to get garbage collected
 prior to calling output buffer callbacks. This triggered fatal errors as a
 result, and to the best of my knowledge the behavior has remained
 unchanged since.

 See #3354 and this (rejected) PHP bug I reported back then:

 https://bugs.php.net/bug.php?id=40104

 Therefor my suggestion for the more conservative approach, i.e. a
 completely separate and independent function, that addresses the php-fpm
 optimization and nothing else.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27122#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform