[wp-trac] [WordPress Trac] #27127: Improve plugin search on installed plugins page
WordPress Trac
noreply at wordpress.org
Sat Feb 15 21:19:26 UTC 2014
#27127: Improve plugin search on installed plugins page
----------------------------+------------------------------
Reporter: enej | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Administration | Version: trunk
Severity: normal | Resolution:
Keywords: | Focuses: ui, javascript
----------------------------+------------------------------
Comment (by enej):
Hi John
Do you think this feature is something that might end up in core?
The latest patch I submitted contains:
- Search for the plugin name and the description only. Since in the
previous patch and your plugin the search looks at everything. So if you
search for edit it would return all plugins instead of finding something
like EditFlow. It would be better if it could search for plugin authors as
well. The regular plugin search does search for plugin authors. But it
also searches html. So if you search 'strong' it will return all the
plugins that have something bolded in the description as well. I will
submit a separate ticket and patch for that.
- The patch also tries to take into account for plugins that have been
selected by the user. It keeps them shown even though they might not match
the users selection. Since when someone selects a plugin they most likely
want to preforms a bulk action. The search fails if you select everything.
Also it doesn't hide the plugin if it is not part of search results and is
unselected.
- If no plugins are found it displays the same no plugins found message as
regular search.
What this patch doesn't have.
- Right now the patch does check if the page has pagination elements but
it doesn't do an ajax call to the backend implemented. Also do we want to
have search results paginated as well?
- This features could should also be implemented for the WordPress
network.
- Also the JavaScript is currently inline. Should it be its own file or
added to one of the existing WordPress JavaScript admin files?
What I am not sure about is would it be best to develop this as a plugin
and the try to do a patch to merge in to core? Or is it best to try to do
a patch that gets merged into core right away? Right now I am trying to
keep things simple by having the patch only modify one file.
Also will this change require a JavaScript unit test and a PHP Unit test?
Cheers
Enej
--
Ticket URL: <https://core.trac.wordpress.org/ticket/27127#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list