[wp-trac] [WordPress Trac] #25169: Optimize all images / pngs in core

[WordPress Trac]

#25169: Optimize all images / pngs in core
------------------------------+--------------------------------------
 Reporter:  bradparbs         |       Owner:  nacin
     Type:  enhancement       |      Status:  reopened
 Priority:  normal            |   Milestone:  3.9
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:  has-patch commit  |     Focuses:  javascript, performance
------------------------------+--------------------------------------
Changes (by netweb):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 This causes numerous issues with `npm install` on Windows installs :(

 I am reopening the ticket because of the console errors from running `npm
 install`. Previously to the addition of `grunt-contrib-imagemin` to
 `package.json` it was an error free build environment for Windows
 contributors.

 Granted I don't think any of the core committers are running Windows to
 commit against core and the crux of this patch is for the the Grunt
 `precommit` task.

 I tested both `grunt-contrib-imagemin` v0.4.1 and v0.5.0 and the errors
 are very similar for both versions.

 Using v0.5.0 fails much more gracefully, you still get similar errors but
 subsequent runs of `npm install` does not try to reinstall the missing
 component.

 == npm install ==

 Using: `"grunt-contrib-imagemin" : "~0.4.1",`
 * npm install console output log:
 https://gist.github.com/ntwb/8dd0e411650142d721ce
 * `npm ERR! weird error 8`
 * `npm ERR! not ok code 0`


 Using: `"grunt-contrib-imagemin" : "~0.5.0",
 * npm install console output log:
 https://gist.github.com/ntwb/146da33743792ed85756

 * `npm WARN optional dep failed, continuing optipng-bin at 0.3.1`

 == grunt build==

 Using: `"grunt-contrib-imagemin" : "~0.4.1",`

 * `>> Local Npm module "grunt-contrib-imagemin" not found. Is it
 installed?`
 * `Done, without errors.`

 Using: `"grunt-contrib-imagemin" : "~0.5.0",
 * `Done, without errors.`

 == grunt precommit ==

 {{{
 Running "imagemin:core" (imagemin) task
 Warning: Cannot find module 'optipng-bin' Use --force to continue.

 Aborted due to warnings.
 C:\xampp\htdocs\develop.wp.nw [trunk]>
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/25169#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform