[wp-trac] [WordPress Trac] #24067: TinyMCE 4.0

[WordPress Trac]

#24067: TinyMCE 4.0
-------------------------+-----------------------
 Reporter:  josh401      |       Owner:  azaozz
     Type:  enhancement  |      Status:  accepted
 Priority:  high         |   Milestone:  3.9
Component:  TinyMCE      |     Version:  3.8
 Severity:  minor        |  Resolution:
 Keywords:               |     Focuses:
-------------------------+-----------------------

Comment (by azaozz):

 Replying to [comment:126 programmin]:
 > Anyone else noticing that _WP_Editors::editor_settings doesn't output
 the plugin, when using add_filter( 'mce_external_plugins', 'myfunction'
 ,12,1);

 Your code works as expected here. TinyMCE 4.0 loads external plugins
 differently: there is a init setting `external_plugins: { 'plugin-name':
 'url-to-the-plugin-file' }` and WP_Editor sets that correctly.

 > This seems to be caused by this, around line 250 of class-wp-editor.php:

 If you look closely you'll see that an old style translation file is not
 required. That code is there for back-compat only. These files are loaded
 only if set with the `'mce_external_languages'` filter. Then each file is
 "marked as done" so TinyMCE doesn't try to load it again. Agree that
 keeping the old `$ext_plugins` variable name is confusing. Not too late to
 change.

 The [http://codex.wordpress.org/Plugin_API/Filter_Reference codex page]
 needs updating. You're welcome to update it too :)

 Replying to [comment:127 josh401]:

 No WP doesn't do anything to the toolbars or the buttons except overriding
 some of the font based icons in editor.css. Looks like a TinyMCE thing.
 Maybe use one of the "dashicons" or add the icon image as background from
 CSS? Both ways will need a little of CSS added to the page.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/24067#comment:128>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform