[wp-trac] [WordPress Trac] #27122: Optimization for PHP FPM

[WordPress Trac]

#27122: Optimization for PHP FPM
-------------------------+------------------------------
 Reporter:  dunglas      |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  General      |     Version:  trunk
 Severity:  normal       |  Resolution:
 Keywords:               |     Focuses:  performance
-------------------------+------------------------------

Comment (by dd32):

 I don't think this is a safe optimization to make unfortunately.

 Consider the scenario where `wp_ob_end_flush_all()` is called mid-pageload
 by plugins for example, which we also do in core:
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/misc.php#L290
 https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-
 wp-upgrader-skins.php#L251

 Perhaps a safer option, would be to conditionally add
 `fastcgi_finish_request` to the `shutdown` action at priority 2? as you
 can see `wp_ob_end_flush_all ()` being used here:
 https://core.trac.wordpress.org/browser/trunk/src/wp-includes/default-
 filters.php#L250

 What do you think @dunglas?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27122#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform