[wp-trac] [WordPress Trac] #27116: Some nav tab and media upload CSS broken in colors.css/wp-admin.css merge

[WordPress Trac]

#27116: Some nav tab and media upload CSS broken in colors.css/wp-admin.css merge
----------------------------+--------------------
 Reporter:  TobiasBg        |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  3.9
Component:  Administration  |     Version:  trunk
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:  ui
----------------------------+--------------------
Changes (by TobiasBg):

 * keywords:  has-patch reporter-feedback => has-patch


Comment:

 Yes, the removed bottom border is for the individual tabs. This becomes
 necessary once the tabs wrap to two lines (due to their number). In that
 case, there's no `.nav-tab-active` tab (which explicitely has a bottom
 border) that then basically pushes all the other ones up one pixel.
 I'm using HTML like the following in a plugin (coming from the themes.php
 HTML for this from previous releases). You can try it with this `<h2>`
 title on any admin screen (i.e. replace the first `<h2>` in the `div.wrap`
 in the Chrome Dev Tools, then reduce the browser width to make the tabs
 wrap):
 {{{
 <h2 class="nav-tab-wrapper">
 <a class="nav-tab nav-tab-active" href="http://...">Foobar</a><a class
 ="nav-tab" href="http://...">Foobar</a><a class="nav-tab"
 href="http://...">Foobar</a><a class="nav-tab"
 href="http://...">Foobar</a><a class="nav-tab"
 href="http://...">Foobar</a>
 <a class="nav-tab" href="http://...">Foobar</a><a class="nav-tab"
 href="http://...">Foobar</a><a class="nav-tab"
 href="http://...">Foobar</a><a class="nav-tab"
 href="http://...">Foobar</a><a class="nav-tab"
 href="http://...">Foobar</a>
 </h2>
 }}}

 For the Thickbox tabs:
 You are right,`border-bottom` is correct here. I had accidentally remove
 `-bottom` as well and didn't notice that it adds the border around the
 entire `#media-upload-header` as the colors are pretty similar.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27116#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform