[wp-trac] [WordPress Trac] #27109: Wrong $parent_file value in wp-admin/update-core.php

[WordPress Trac]

#27109: Wrong $parent_file value in wp-admin/update-core.php
----------------------------------------+------------------------------
 Reporter:  SergeyBiryukov              |       Owner:
     Type:  defect (bug)                |      Status:  new
 Priority:  normal                      |   Milestone:  Awaiting Review
Component:  Upgrade/Install             |     Version:  3.0
 Severity:  normal                      |  Resolution:
 Keywords:  good-first-bug needs-patch  |     Focuses:  administration
----------------------------------------+------------------------------
Description changed by SergeyBiryukov:

Old description:

> When Updates menu item was moved from Tools to Dashboard in [13588],
> `$parent_file` was not updated:
> [source:tags/3.8.1/src/wp-admin/update-core.php#L459]
>
> `get_admin_page_parent()` correctly overrides it with `index.php`. This
> leaves me wondering if the explicit declaration is actually necessary,
> but have it on other admin screens as well, so let's just update it.

New description:

 When Updates menu item was moved from Tools to Dashboard in [13588],
 `$parent_file` was not updated: [source:tags/3.8.1/src/wp-admin/update-
 core.php#L459].

 `get_admin_page_parent()` correctly overrides it with `index.php`. This
 leaves me wondering if the explicit declaration is actually necessary, but
 have it on other admin screens as well, so let's just update it.

--

--
Ticket URL: <https://core.trac.wordpress.org/ticket/27109#comment:1>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform